Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved skills support, secondary skills and socketed gem modifiers #556

Merged
merged 15 commits into from Mar 11, 2020

Conversation

brather1ng
Copy link
Member

First part of #546.

Most of this happened in the Engine (see PoESkillTree/PoESkillTree.Engine#6 and PoESkillTree/PoESkillTree.Engine#7). This does mainly two things:

  1. Split skill parsing into two steps: gem parsing and skill parsing.
  2. Allow modifying the skills in between: additional level and quality (values come from the Engine) and enabling/disabling skills of gems that have secondary skills individually.

For active skills with secondary skills, enabling/disabling them can be done in the Skills UI:
image

@brather1ng brather1ng added this to the 3.0.0-beta.1 milestone Mar 11, 2020
@brather1ng brather1ng merged commit 3bf850c into master Mar 11, 2020
@brather1ng brather1ng deleted the engine-skills-update branch March 11, 2020 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant