Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack: Expression won't be evaluated. #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Fantasime
Copy link

In this case:

NanoLog::setLogLevel(NOTICE);
int val = 0;
NANO_LOG(DEBUG, "This value %d won't be printed.", val++);

the value of val is still 0 because of code at line 1087~1089 in runtime/NanoLogCpp17.h:

if (NanoLog::severity > NanoLog::getLogLevel())
    break;

I moved it to function NanoLogInternal::log to make VA_ARGS be evaluated.
See an additional test case in integrationTest/main.cc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant