When using jQuery-UI autocomplete, honour _renderItem extension point; use \n as a delimiter #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfonsomunozpomer
changed the title
alfonsomunozpomer
added a commit
to ebi-gene-expression-group/atlas
that referenced
this pull request
Feb 24, 2016
…dex - Use \n as delimiter; honour _renderItem in jQuery-UI autocomplete Pixabay/jQuery-tagEditor#77
Using the public method addTag with a duplicate causes two empty tags to be inserted before the duplicate at the end. Support is removed until it works perfectly.
…ee a portable way to support it for OS X as well (metaKey); besides it’s ugly as it shows the hidden separator char
Using the public method addTag with a duplicate causes two empty tags to be inserted before the duplicate at the end. Support is removed until it works perfectly. (cherry picked from commit 2bc18ea)
(cherry picked from commit 11d4a96)
(cherry picked from commit e451455)
…ee a portable way to support it for OS X as well (metaKey); besides it’s ugly as it shows the hidden separator char (cherry picked from commit ae3123b)
…editor does to a minimum
…ring; add tag object fields as data attributes to the <div class="tag-editor-tag"> element
…rk; input is parsed as JSON only (no objects are accepted anymore)
…hes with the regular tag editor
…ss all browsers; minor code clean-up
…g isn’t there yet and we can’t retrieve the data attribute
…ray of strings, array of objects or JSON array
…value is displayed (instead of a “big enough” number)
…to the assign clause.
I saw that the properties of $(e).get(0).dataset are enumerable in Chrome, but not in Safari. This makes the tags object be empty every time, because - as MDN explains - Object.assign only copies own and enumerable properties.
Make onChange work on Safari
…plete.plugin. To use with ArrayExpress EFO autocomplete. See ebi-gene-expression-group/atlas@96e117b and https://github.com/arrayexpress/ae-interface/blob/master/webapp/src/main/webapp/assets/scripts/jquery.autocomplete-1.1.0.150319.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _renderItem extension in autocomplete is called if it’s been defined.
When pasting multiline text, split into tags if \n is a delimiter character.