Optimistic handling of replication status, when quorum is simply lost… #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… we do not reset slave
|
This should fix issue #61. |
y-trudeau
approved these changes
Mar 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… we do not reset slave
In some situations when a slave get disconnected i.e. network issues, the agent would think the master has crashed. However, this node may only have been split from the cluster and losing quorum - therefore we should take this into account and not immediately unset_master before the MYSQL instance is stopped, it should be preserved and resumed when the node rejoins the cluster. If at MySQL startup and the agent detects the preserved replication status Master_host does not match the current master host, then replication will be reset.