Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pl-device-test fix: do not differentiate Projector with respect to state #5683

Merged
merged 9 commits into from
May 14, 2024

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented May 13, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    test directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the doc/releases/changelog-dev.md file, summarizing the
    change, and including a link back to the PR.

  • The PennyLane source code conforms to
    PEP8 standards.
    We check all of our code against Pylint.
    To lint modified files, simply pip install pylint, and then
    run pylint pennylane/path/to/file.py.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:
Use vanilla NumPy arrays in test_projector_expectation to avoid differentiating qml.Projector with respect to the state attribute.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@vincentmr vincentmr changed the title Do not differentiate Projector with respect to states. pl-device-test fix: do not differentiate Projector with respect to state May 13, 2024
@trbromley
Copy link
Contributor

Thanks @vincentmr! Which Shortcut story does this correspond to?

So the objective here is to get things compatible with lightning.kokkos? I'm just worried in case there is a test regression for other devices.

@vincentmr
Copy link
Contributor Author

[sc-63107]

@vincentmr
Copy link
Contributor Author

Thanks @vincentmr! Which Shortcut story does this correspond to?

So the objective here is to get things compatible with lightning.kokkos? I'm just worried in case there is a test regression for other devices.

We do not differentiate Projector w.r.t. state in the tests, but lightning.kokkos and (likely) lightning.gpu are trying to differentiate it since the parameter is pennylane.numpy. This is to restore compatibility with the Lightning devices.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.67%. Comparing base (9c9b6ba) to head (fc49d84).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5683      +/-   ##
==========================================
- Coverage   99.68%   99.67%   -0.01%     
==========================================
  Files         412      414       +2     
  Lines       38666    38522     -144     
==========================================
- Hits        38545    38398     -147     
- Misses        121      124       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vincentmr vincentmr marked this pull request as ready for review May 14, 2024 16:50
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vincentmr!

@vincentmr vincentmr merged commit be35a7b into master May 14, 2024
39 checks passed
@vincentmr vincentmr deleted the bugfix/lkokkos_tests branch May 14, 2024 17:11
Shiro-Raven pushed a commit that referenced this pull request May 15, 2024
…state (#5683)

### Before submitting

Please complete the following checklist when submitting a PR:

- [x] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
      test directory!

- [x] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
      render correctly by running `make docs`.

- [ ] Ensure that the test suite passes, by running `make test`.

- [x] Add a new entry to the `doc/releases/changelog-dev.md` file,
summarizing the
      change, and including a link back to the PR.

- [x] The PennyLane source code conforms to
      [PEP8 standards](https://www.python.org/dev/peps/pep-0008/).
We check all of our code against [Pylint](https://www.pylint.org/).
      To lint modified files, simply `pip install pylint`, and then
      run `pylint pennylane/path/to/file.py`.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


------------------------------------------------------------------------------------------------------------

**Context:**

**Description of the Change:**
Use vanilla NumPy arrays in `test_projector_expectation` to avoid
differentiating `qml.Projector` with respect to the state attribute.

**Benefits:**

**Possible Drawbacks:**

**Related GitHub Issues:**
@vincentmr
Copy link
Contributor Author

[sc-63451]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants