Make CommutingEvolution a SymbolicOp
#5682
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
albi3ro
reviewed
May 13, 2024
|
|
||
| .. math:: O = O_1 O_2 \dots O_n. | ||
| def matrix(self, wire_order=None) -> TensorLike: | ||
| """Raise a MatrixUndefinedError for now to force decomposition on DefaultQubit.""" |
There was a problem hiding this comment.
Potentially instead we can treat this like GroverOperator and QFT and manually say "decompose CommutingEvolution".
albi3ro
reviewed
May 13, 2024
Comment on lines
+162
to
+163
| def _matrix(scalar, mat): | ||
| return qml.math.expm(-1j * scalar * mat) |
There was a problem hiding this comment.
Potentially we could make _matrix not an abstractmethod? Then we woudn't need to define this.
There was a problem hiding this comment.
Actually, do we want to do the following, @albi3ro ?
- Keep this
_matrixmethod, removing the need for a custommatrixmethod. - Thus, remove
matrix - Remove
has_matrix, becauseScalarSymbolicOpalready sets it toself.base.has_matrix, and_matrixis all that is needed to go from the Hamitlonian matrix to theCommutingEvolutionmatrix. - Add a logic for
apply_operationforCommutingEvolutionlike forGroverOperatoretc
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5682 +/- ##
==========================================
- Coverage 99.68% 99.67% -0.01%
==========================================
Files 415 415
Lines 38886 38602 -284
==========================================
- Hits 38762 38477 -285
- Misses 124 125 +1 ☔ View full report in Codecov by Sentry. |
dwierichs
added
the
review-ready 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
CommutingEvolutionhas the structure of aScalarSymbolicOp, so we make it one.Description of the Change:
Change base class of
CommutingEvolutionand adapt other attributes of the class to this change.In addition, a dispatch branch of
qml.equalfor allScalarSymbolicOps is introduced.Benefits:
Code quality
Possible Drawbacks:
Related GitHub Issues: