-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate simplify
argument in qml.ops.Hamiltonian
and qml.LinearCombination
#5677
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5677 +/- ##
==========================================
- Coverage 99.68% 99.67% -0.01%
==========================================
Files 415 415
Lines 38878 38588 -290
==========================================
- Hits 38754 38463 -291
- Misses 124 125 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also worth adding a comment under for the description of simplify
in the docstrings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @PietropaoloFrisoni!
A reminder to everyone to check the docs build before approving/merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @PietropaoloFrisoni!
Context: Part of deprecations and removals for pennylane-0.37
Description of the Change: Deprecating the
simplify
argument inqml.ops.Hamiltonian
andqml.ops.LinearCombination
in favour ofqml.simplify()
.[sc-59086]