Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate simplify argument in qml.ops.Hamiltonian and qml.LinearCombination #5677

Merged
merged 24 commits into from
May 16, 2024

Conversation

PietropaoloFrisoni
Copy link
Contributor

@PietropaoloFrisoni PietropaoloFrisoni commented May 10, 2024

Context: Part of deprecations and removals for pennylane-0.37

Description of the Change: Deprecating the simplify argument in qml.ops.Hamiltonian and qml.ops.LinearCombination in favour of qml.simplify().

[sc-59086]

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.67%. Comparing base (0dcb866) to head (95f5669).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5677      +/-   ##
==========================================
- Coverage   99.68%   99.67%   -0.01%     
==========================================
  Files         415      415              
  Lines       38878    38588     -290     
==========================================
- Hits        38754    38463     -291     
- Misses        124      125       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PietropaoloFrisoni PietropaoloFrisoni marked this pull request as ready for review May 14, 2024 20:00
@albi3ro albi3ro self-requested a review May 15, 2024 16:34
Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also worth adding a comment under for the description of simplify in the docstrings.

Copy link
Contributor

@trbromley trbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PietropaoloFrisoni!

A reminder to everyone to check the docs build before approving/merging.

doc/development/deprecations.rst Show resolved Hide resolved
pennylane/ops/op_math/linear_combination.py Outdated Show resolved Hide resolved
pennylane/ops/op_math/linear_combination.py Outdated Show resolved Hide resolved
Copy link
Contributor

@trbromley trbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pennylane/ops/op_math/linear_combination.py Outdated Show resolved Hide resolved
doc/development/deprecations.rst Outdated Show resolved Hide resolved
doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
pennylane/ops/qubit/hamiltonian.py Outdated Show resolved Hide resolved
@PietropaoloFrisoni PietropaoloFrisoni enabled auto-merge (squash) May 16, 2024 17:07
@PietropaoloFrisoni PietropaoloFrisoni merged commit 6855709 into master May 16, 2024
38 checks passed
@PietropaoloFrisoni PietropaoloFrisoni deleted the Deprecate_simplify_argument branch May 16, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants