Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty PauliVSpace init #5675

Merged
merged 15 commits into from
May 17, 2024
Merged

Allow empty PauliVSpace init #5675

merged 15 commits into from
May 17, 2024

Conversation

Qottmann
Copy link
Contributor

In situations where one wants to iteratively build up a PaulIVSpace it is handy to be able to initialize an empty PauliVSpace. This is currently not possible and fixed with this PR.

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.67%. Comparing base (5b81a8a) to head (8156975).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5675      +/-   ##
==========================================
- Coverage   99.68%   99.67%   -0.01%     
==========================================
  Files         415      415              
  Lines       38886    38596     -290     
==========================================
- Hits        38762    38471     -291     
- Misses        124      125       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dwierichs dwierichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Qottmann , that's a nice catch!

Would you mind adding your name to the changelog? :)

pennylane/pauli/dla/lie_closure.py Outdated Show resolved Hide resolved
@Alex-Preciado
Copy link
Contributor

Alex-Preciado commented May 10, 2024

[sc-63068]

@Qottmann Qottmann enabled auto-merge (squash) May 10, 2024 22:04
@Qottmann Qottmann disabled auto-merge May 13, 2024 06:50
@Qottmann Qottmann enabled auto-merge (squash) May 14, 2024 09:04
@Qottmann Qottmann disabled auto-merge May 17, 2024 07:12
@Qottmann Qottmann enabled auto-merge (squash) May 17, 2024 07:13
@Qottmann Qottmann merged commit 59c3287 into master May 17, 2024
38 checks passed
@Qottmann Qottmann deleted the emptypaulivspace branch May 17, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants