Update mapping support in qchem #5657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## qchem_feature_branch #5657 +/- ##
========================================================
- Coverage 99.67% 99.67% -0.01%
========================================================
Files 416 416
Lines 38843 38390 -453
========================================================
- Hits 38717 38264 -453
Misses 126 126 ☔ View full report in Codecov by Sentry. |
soranjh
changed the title
ddhawan11
changed the base branch from
molecule_central_object
to
qchem_feature_branch
soranjh
reviewed
May 22, 2024
There was a problem hiding this comment.
Thanks @ddhawan11, looks good overall. We need to make sure that the pyscf backend is also checked with different mappings.
|
[sc-62837] |
trbromley
reviewed
May 24, 2024
soranjh
requested changes
May 24, 2024
There was a problem hiding this comment.
Good work @ddhawan11. Couple of changes but otherwise I think it's good.
ddhawan11
changed the title
soranjh
approved these changes
May 27, 2024
There was a problem hiding this comment.
Thanks @ddhawan11, looks good. Please update the changelog before merging.
austingmhuang
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
added different mappings to molecular_hamiltonian function
Description of the Change:
molecular Hamiltonian can be mapped using different mapping schemes.
Benefits:
Possible Drawbacks:
Related GitHub Issues: