Use persistBlock parameter in DCAS.getBlock() #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to not persist to our blockstore (but can still cache) blocks that been requested by a client.
kevodwyer
reviewed
Oct 23, 2023
src/peergos/server/storage/DeletableContentAddressedStorage.java
Outdated
Show resolved
Hide resolved
kevodwyer
approved these changes
Oct 23, 2023
kevodwyer
approved these changes
Oct 24, 2023
This will cause GC to error trying tyo delete non-existent blocks
Rename and simplify MetadataCachingStorage
Always persist blocks for now.
Mirroring should persist block, but the following should not: * checking mutable pointer commits * space usage calculation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to not persist to our blockstore
(but can still cache) blocks that been requested
by a client.