Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for prom-client v13 #65

Merged
merged 7 commits into from Mar 4, 2021
Merged

Support for prom-client v13 #65

merged 7 commits into from Mar 4, 2021

Conversation

yorch
Copy link
Contributor

@yorch yorch commented Feb 16, 2021

@yorch
Copy link
Contributor Author

yorch commented Feb 16, 2021

Fixes #64, #61 and #63

@yorch
Copy link
Contributor Author

yorch commented Feb 23, 2021

@kobik gently reminder :) would be great to merge this, thanks!

Copy link
Collaborator

@kobik kobik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yorch!

Can you please add the breaking change to the Changelog file?

@yorch
Copy link
Contributor Author

yorch commented Feb 28, 2021

@kobik sure.. done!

@kobik
Copy link
Collaborator

kobik commented Mar 3, 2021

@kobik sure.. done!

thanks @yorch

@yorch
Copy link
Contributor Author

yorch commented Mar 4, 2021

@kobik thanks for the approval, unfortunately I cannot merge this as I don't have privileges.

@kobik
Copy link
Collaborator

kobik commented Mar 4, 2021

@yorch is like to merge and release both this and custom labels together, that's why I didn't merge it yet

@yorch
Copy link
Contributor Author

yorch commented Mar 4, 2021

@kobik still not sure I follow, eventually you will have to merge one of these first and then the other. Most likely, one of these is gonna cause conflicts with the other that wont bubble up until one of these is merged

@kobik kobik merged commit 35f64a9 into PayU:master Mar 4, 2021
@yorch yorch deleted the prom-client-13 branch March 4, 2021 17:44
@kobik
Copy link
Collaborator

kobik commented Mar 8, 2021

@yorch , i've made some tests on my end and the current version works with both prom-client 12 and 13, so i think we can bump it by a minor version.

what do you think?

do you see a real reason for bumping a major version?

@yorch
Copy link
Contributor Author

yorch commented Mar 8, 2021

@kobik agree, since there are not actual break changes then if it still works with 12, makes sense to keep the update as a minor version 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants