Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add 'HTML_NAMESPACE' (used in tests) #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

njam
Copy link

@njam njam commented Feb 2, 2020

Just making the code compile

cargo check --all-targets

The const HTML_NAMESPACE is used in the same file, in the tests module.
Not sure if you prefer defining the constant in the tests module, to avoid it being "dead code"?

Copy link
Owner

@Pauan Pauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, yeah I'd rather just change the tests to use html! instead.

@njam
Copy link
Author

njam commented Feb 2, 2020

Hm, the tests are using DomBuilder, but html! is creating Dom.
I've now replaced DomBuilder::new(create_element_ns(...)) with DomBuilder::new_html(...), does that make sense?

@njam
Copy link
Author

njam commented Feb 2, 2020

btw, how are you running the tests? :D

I tried running tests with "wasm-bindgen-test" in Chrome, and got 3/6 failing tests.

@Pauan
Copy link
Owner

Pauan commented Oct 21, 2021

Oh, I'm sorry, I somehow missed this issue. I don't actually run any of the tests, I just use them for compile-time type checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants