Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align SQL server major version with chocolatey #15

Merged
merged 3 commits into from Mar 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Expand Up @@ -16,9 +16,9 @@ jobs:
matrix:
include:
- name: Windows
os: windows-2019
os: windows-2022
- name: Linux
os: ubuntu-20.04
os: ubuntu-22.04
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -4,7 +4,7 @@ This action installs and runs SQL Server for a GitHub Actions workflow.

1. Installs SQL Server
* On Windows, uses [Chocolatey](https://chocolatey.org/) to install [SQL Server Express](https://community.chocolatey.org/packages/sql-server-express).
* On Linux, runs SQL as a Docker container using the `mcr.microsoft.com/mssql/server:2017-latest` image.
* On Linux, runs SQL as a Docker container using the `mcr.microsoft.com/mssql/server:2022-latest` image.
1. Creates environement variables for a connection string and for `sqlcmd`.
1. Waits for the SQL instance to be accessible.
1. Creates a default database catalog.
Expand Down
2 changes: 1 addition & 1 deletion action.yml
Expand Up @@ -39,7 +39,7 @@ runs:
echo "::add-mask::$sa_pw"

echo "Starting SQL Server in a Docker container..."
docker run -e "ACCEPT_EULA=Y" -e "SA_PASSWORD=$sa_pw" -e "MSSQL_PID=Developer" -e "MSSQL_COLLATION=SQL_Latin1_General_CP1_CS_AS" -p 1433:1433 --name sqlserver -d mcr.microsoft.com/mssql/server:2017-latest
docker run -e "ACCEPT_EULA=Y" -e "SA_PASSWORD=$sa_pw" -e "MSSQL_PID=Developer" -e "MSSQL_COLLATION=SQL_Latin1_General_CP1_CS_AS" -p 1433:1433 --name sqlserver -d mcr.microsoft.com/mssql/server:2022-latest

echo "Setting environment variables for sqlcmd..."
echo "SQLCMDPASSWORD=$sa_pw" >> $GITHUB_ENV
Expand Down