Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove community maintained project docs and samples #6533

Merged
merged 5 commits into from Apr 9, 2024

Conversation

@soujay soujay self-assigned this Mar 27, 2024
@soujay soujay marked this pull request as draft March 27, 2024 20:05
@soujay soujay marked this pull request as ready for review March 27, 2024 21:51
@soujay soujay changed the title Remove community maintained project samples Remove community maintained project docs and samples Mar 27, 2024
Copy link
Contributor

@tamararivera tamararivera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing the clean up!

@@ -585,8 +572,6 @@
Articles:
- Url: nservicebus/testing
Title: About testing NServiceBus
- Url: samples/unit-testing
Title: AAA style tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Why did you remove this one?
It looks like it is out of place but it is maybe still useful?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tamararivera - This is a duplicate link in the left nav. There is already a link for this under samples. I removed this as the one under samples is more appropriate place

  • Samples - General- Unit Testing NServiceBus

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was probably deliberately put there. The history is that we used to have fluent style tests. During the transition, we put the sample up there to lead people towards using the AAA style tests. Now that the fluent API style is no longer supported, the sample up there is indeed "duplicated".

nservicebus/community/index.md Show resolved Hide resolved
Copy link
Contributor

@danielmarbach danielmarbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing the redirects would be an important thing to do in this PR. Other than that, thanks for the nice cleanup!

@@ -585,8 +572,6 @@
Articles:
- Url: nservicebus/testing
Title: About testing NServiceBus
- Url: samples/unit-testing
Title: AAA style tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was probably deliberately put there. The history is that we used to have fluent style tests. During the transition, we put the sample up there to lead people towards using the AAA style tests. Now that the fluent API style is no longer supported, the sample up there is indeed "duplicated".

nservicebus/community/index.md Show resolved Hide resolved
@soujay soujay merged commit 9766c0d into master Apr 9, 2024
4 checks passed
@soujay soujay deleted the remove-community-maintained-project-samples branch April 9, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants