New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove community maintained project docs and samples #6533
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing the clean up!
@@ -585,8 +572,6 @@ | |||
Articles: | |||
- Url: nservicebus/testing | |||
Title: About testing NServiceBus | |||
- Url: samples/unit-testing | |||
Title: AAA style tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Why did you remove this one?
It looks like it is out of place but it is maybe still useful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tamararivera - This is a duplicate link in the left nav. There is already a link for this under samples. I removed this as the one under samples is more appropriate place
- Samples - General- Unit Testing NServiceBus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was probably deliberately put there. The history is that we used to have fluent style tests. During the transition, we put the sample up there to lead people towards using the AAA style tests. Now that the fluent API style is no longer supported, the sample up there is indeed "duplicated".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing the redirects would be an important thing to do in this PR. Other than that, thanks for the nice cleanup!
@@ -585,8 +572,6 @@ | |||
Articles: | |||
- Url: nservicebus/testing | |||
Title: About testing NServiceBus | |||
- Url: samples/unit-testing | |||
Title: AAA style tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was probably deliberately put there. The history is that we used to have fluent style tests. During the transition, we put the sample up there to lead people towards using the AAA style tests. Now that the fluent API style is no longer supported, the sample up there is indeed "duplicated".
This PR removes docs and samples based off community maintained projects.
Docs that have been removed
Samples that have been removed
Add the router to the community project list /nservicebus/community/
Additional Context - https://particularsoftware.slack.com/archives/C04SQ8A1N/p1711518706360469