Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persistence changes #4024

Merged
merged 22 commits into from Mar 27, 2024
Merged

Persistence changes #4024

merged 22 commits into from Mar 27, 2024

Conversation

danielmarbach
Copy link
Contributor

@danielmarbach danielmarbach commented Mar 21, 2024 •
edited by bording

This PR makes the following changes to the persistence seam:

  • We can now guard against accidentally restarting the embedded RavenDB server while we are shutting down
  • The primary RavenDB persister now uses IRavenDocumentStoreProvider model like the audit persister had, which solves the initialization problem that we previously needed the custom IHostLifetime implementations to work around.
  • Other changes have been made to align persistence concepts between the primary and audit instances, and to better align how the persisters interact with IHostApplicationBuilder being used to bootstrap the instances.

@mauroservienti mauroservienti changed the title Guard against accidentally restarting the embedded ravendb server while we are shutting down Guard against accidentally restarting the embedded RavenDb server while we are shutting down Mar 22, 2024
danielmarbach and others added 11 commits March 26, 2024 10:10
@danielmarbach
Guard against accidentally restarting the server while we are shuttin…
322301a 
…g down
@mauroservienti @danielmarbach
Use IHostApplicationLifetime to detect ServiceControl is shutting dow…
63f3fad 
…n and RavenDB doesn't need to be restarted (#4025)

* Use IHostApplicationLifetime to detect it's shutting down

* Mock IHostApplicationLifetime for tests
@danielmarbach @mauroservienti
Align audit embedded database, simplify DI integration
c2c07ee 
Get rid of MockHostApplicationLifetime

Co-authored-by: Mauro Servienti <mauro.servienti@gmail.com>
@danielmarbach
Simplify and align persistence seam further
45a2d1a
@danielmarbach
Fix setup not having application lifetime available
3ce498b
@danielmarbach
Switch the audit setup command to use a host and make the installer a…
6ae167b 
… hosted service
@mauroservienti @danielmarbach
Move persistence config into a dedicated AddServiceControlAuditInstal…
8455539 
…lers extension (#4029)
@danielmarbach
Cleanup audit store
53c52b5
@danielmarbach
Inline the lifecycle concept into the persistence
b0b7c42
@danielmarbach
Align name with primary
7864564
@danielmarbach
Attempt to convert the primary seam (WIP)
25ad59e
@bording bording changed the title Guard against accidentally restarting the embedded RavenDb server while we are shutting down Persistence changes Mar 27, 2024
@bording bording merged commit df9a6cf into master Mar 27, 2024
19 checks passed
@bording bording deleted the ravendb-embedded-shutdown branch March 27, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauroservienti mauroservienti mauroservienti approved these changes

@bording bording bording approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danielmarbach @bording @mauroservienti