Remove ServicePointManager usage #4020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmarbach
changed the title
mauroservienti
approved these changes
Mar 20, 2024
…y .NET is moving away from ServicePointManager
…e anymore with modern HTTP Client usage. We have decided against adding a log warning since generally it is OK to have settings in app.config that are no longer relevant.
danielmarbach
force-pushed
the
service-point-manager
branch
from
d9cf8e7
to
5398b14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the ServicePointManager usage. With NET ServicePointManager become largely either useless since the HTTP connections are now managed on the HTTP clients or no longer best practice to call. The acceptance test cases contained tweaks that were put in place during a time when the underlying transport SDKs were using web requests instead of HTTP Client. With the more modern versions of the transport, this is no longer necessary. Furthermore, we have also largely embarked on a journey where we configure the throughput relevant defaults that make sense for SC within the transport seam.
For the production code we have decided to remove the
HttpDefaultConnectionLimitsince there is no global way anymore to manage those connections. Should we need a way to handle connection limits for various cases, we can introduce dedicated settings again in the future. While this is a "breaking change" that will roll out in a minor potentially, we have concluded adding a log warning is not really helping much other than indicating to a user the potential for cleaning up the app.config file.