Logging fixes and improvements #4019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased |
bording
force-pushed
the
logging
branch
2 times, most recently
from
b185d5b
to
2359609
Compare
src/ServiceControl.AcceptanceTests/TestSupport/ServiceControlComponentRunner.cs
Show resolved
Hide resolved
danielmarbach
approved these changes
Mar 22, 2024
mauroservienti
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem where the NServiceBus logger was being used before NLog had been configured, so the default logger's text files would end up being written to the instance installation folders.
This also cleans up how logging settings were being passed around and makes the logging configuration more consistent across all three instance types.