Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring todo #4007

Merged
merged 3 commits into from Mar 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -1,4 +1,4 @@
namespace ServiceControl.Audit.Infrastructure.OWIN
namespace ServiceControl.Audit.Infrastructure.WebApi
{
using System.Threading.Tasks;
using Microsoft.AspNetCore.Http;
Expand Down
2 changes: 1 addition & 1 deletion src/ServiceControl.Audit/WebApplicationExtensions.cs
@@ -1,7 +1,7 @@
namespace ServiceControl.Audit;

using Infrastructure.WebApi;
using Microsoft.AspNetCore.Builder;
using Infrastructure.OWIN;

public static class WebApplicationExtensions
{
Expand Down
Expand Up @@ -82,7 +82,7 @@ await Define<TestContext>()
return false;
}

// TODO this should be using camalCase (the same for a few other monitoring acceptance tests, something sounds off with the json options
// Metric names are fixed names and therefore are not following the casing rules of the chosen serializer
if (monitoredEndpointDetails.Digest.Metrics.TryGetValue("QueueLength", out var queueLength) && queueLength.Average == 0.0)
{
return false;
Expand Down

This file was deleted.

@@ -1,4 +1,4 @@
namespace ServiceControl.Infrastructure.OWIN
namespace ServiceControl.Infrastructure.WebApi
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should consider removing the route URL fixes after some research

{
using System.Threading.Tasks;
using Microsoft.AspNetCore.Http;
Expand Down
2 changes: 1 addition & 1 deletion src/ServiceControl/WebApplicationExtensions.cs
@@ -1,7 +1,7 @@
namespace ServiceControl;

using Infrastructure.OWIN;
using Infrastructure.SignalR;
using Infrastructure.WebApi;
using Microsoft.AspNetCore.Builder;

public static class WebApplicationExtensions
Expand Down