Use PeriodicTimer in the async timer #4004
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the internals of AsyncTimer to using PeriodicTimer which is built-in. To support the due time and to avoid having to change the period of the timer it first delays for the due time and then waits until the period fires. The previous implementation did essentially prolong the execution of the next interval by the time it took the callback to execute. This implementation changes the behavior slightly by checking if the next tick is available, which might already be. If multiple periods are over, those get coalesced into one execution.
Do you see any issues with this potentially firing a bit earlier? It would be nice to be able to rely on the provided period timer.