Remove CatchAll and body ID manipulation since it should no longer be needed #3987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the unique message id which is a deterministic ID that doesn't contain slashes Co-authored-by: Mauro Servienti <mauro.servienti@gmail.com>
…ould not contain slashes anymore Co-authored-by: Mauro Servienti <mauro.servienti@gmail.com>
… worked Co-authored-by: Mauro Servienti <mauro.servienti@gmail.com>
danielmarbach
force-pushed
the
message-id
branch
from
9c051ee
to
cd1edaf
Compare
mauroservienti
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mauroservienti and I tried to reason about the code and came to the conclusion in all the cases we either use the
UniqueId()which is a deterministic ID that doesn't contain slashes or the route that would have contained slashes can never arrive because the controller would try to match a route that doesn't exist. The catch-all would not have caught these cases since it was explicitly hard-coded against only looking for cases when the body was attempted to load, which has also be changed a while ago to use the same unique ID.