Update to NServiceBus 9 #3986
Merged
Update to NServiceBus 9 #3986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| var app = hostBuilder.Build(); |
There was a problem hiding this comment.
This is a general comment. Not something we have to address though. I was wondering if it would still be better from a code flow perspective to do using. The app is disposable and from that perspective it would make sense to add a using. Otherwise we are relying on knowledge of implementation details of RunAsync which I'm a little bit on the fence but I can see the argument of "yeah but how the code is right now is more aligned with the default templates of MS that also relies on RunAsync doing the dispose"
danielmarbach
approved these changes
Mar 7, 2024
mauroservienti
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates ServiceControl to use NServiceBus 9 and uses the MSMQ source packages provided by NSB9 to bring back the MSMQ support.