Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dispose not being invoked #3923

Merged
merged 1 commit into from Mar 1, 2024
Merged

Fix dispose not being invoked #3923

merged 1 commit into from Mar 1, 2024

Conversation

ramonsmits
Copy link
Member

Fix dispose not being invoked and aligned all command runners to use using var

@mauroservienti
Copy link
Member

Not sure we want to bring this into the net8 branch. In the primary instance, we drastically changed the way bootstrapping works and got rid of the bootstrapper class.

@ramonsmits
Copy link
Member Author

@mauroservienti I know, that is why I applied it on this branch to not have any merge conflicts that need to be resolved later

@mauroservienti
Copy link
Member

@ramonsmits, I lost track of this PR. Do we still need to bring this into the net8 branch?

@ramonsmits
Copy link
Member Author

@mauroservienti I've updated the branch as the problem still exists on master

@danielmarbach danielmarbach merged commit 0bc8564 into master Mar 1, 2024
19 checks passed
@danielmarbach danielmarbach deleted the dispose branch March 1, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants