Skip to content

Commit

Permalink
Ensure RavenDB download script is used when WindowsSelfContained is true
Browse files Browse the repository at this point in the history
  • Loading branch information
bording committed Mar 4, 2024
1 parent 0bbfa12 commit 956903b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
Expand Up @@ -32,7 +32,8 @@
a CI build, this is skipped because the CI and Release workflows have already downloaded a self-contained version of RavenDB
to that location already.
-->
<Artifact Condition="'$(CI)' != 'true'" Include="$(OutputPath)\RavenDBServer" DestinationFolder="$(ArtifactsPath)RavenDBServer" />
<!-- This is also skipped when WindowsSelfContained is true to ensure a self-contained RavenDB is embedded. -->
<Artifact Condition="'$(CI)' != 'true' And '$(WindowsSelfContained)' != 'true'" Include="$(OutputPath)\RavenDBServer" DestinationFolder="$(ArtifactsPath)RavenDBServer" />
</ItemGroup>

</Project>
Expand Up @@ -40,6 +40,7 @@
</Target>

<Target Name="PrepareCreateZipFiles" DependsOnTargets="GetDuplicateInstanceFiles">
<Error Condition="!Exists('$(ArtifactsPath)$(RavenDBServer)')" Text="The 'download-ravendb-server.ps1' PowerShell script needs to be run before building when running a CI or WindowsSelfContained build." />

This comment has been minimized.

Copy link
@danielmarbach

danielmarbach Mar 4, 2024

Contributor

That's neat and helpful! Good stuff

<ItemGroup>
<PrimaryFilesToZip Include="$(ArtifactsPath)$(Primary)\**\*" />
<AuditFilesToZip Include="$(ArtifactsPath)$(Audit)\**\*" />
Expand Down

0 comments on commit 956903b

Please sign in to comment.