Skip to content

Commit

Permalink
Monitoring todo (#4007)
Browse files Browse the repository at this point in the history
* Delete unneeded class

* Replace TODO with explanation

* Removed OWIN namespace and folder
  • Loading branch information
danielmarbach committed Mar 15, 2024
1 parent efb2c2b commit 2972ea4
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 20 deletions.
@@ -1,4 +1,4 @@
namespace ServiceControl.Audit.Infrastructure.OWIN
namespace ServiceControl.Audit.Infrastructure.WebApi
{
using System.Threading.Tasks;
using Microsoft.AspNetCore.Http;
Expand Down
2 changes: 1 addition & 1 deletion src/ServiceControl.Audit/WebApplicationExtensions.cs
@@ -1,7 +1,7 @@
namespace ServiceControl.Audit;

using Infrastructure.WebApi;
using Microsoft.AspNetCore.Builder;
using Infrastructure.OWIN;

public static class WebApplicationExtensions
{
Expand Down
Expand Up @@ -82,7 +82,7 @@ await Define<TestContext>()
return false;
}
// TODO this should be using camalCase (the same for a few other monitoring acceptance tests, something sounds off with the json options
// Metric names are fixed names and therefore are not following the casing rules of the chosen serializer
if (monitoredEndpointDetails.Digest.Metrics.TryGetValue("QueueLength", out var queueLength) && queueLength.Average == 0.0)
{
return false;
Expand Down

This file was deleted.

@@ -1,4 +1,4 @@
namespace ServiceControl.Infrastructure.OWIN
namespace ServiceControl.Infrastructure.WebApi
{
using System.Threading.Tasks;
using Microsoft.AspNetCore.Http;
Expand Down
2 changes: 1 addition & 1 deletion src/ServiceControl/WebApplicationExtensions.cs
@@ -1,7 +1,7 @@
namespace ServiceControl;

using Infrastructure.OWIN;
using Infrastructure.SignalR;
using Infrastructure.WebApi;
using Microsoft.AspNetCore.Builder;

public static class WebApplicationExtensions
Expand Down

0 comments on commit 2972ea4

Please sign in to comment.