Obsolete message for DateTimeExtensions points to wrong replacement class #6976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The obsolete message on the class type was referencing to DateTimeOffsetHelper that is an internal class. Instead, it should be DateTimeOffsetExtensions, like correctly is on all class members
|
Shouldn't the description in the PR be
? |
danielmarbach
approved these changes
Mar 18, 2024
bording
approved these changes
Mar 18, 2024
bording
changed the title
bording
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The obsolete message on the class type referred to
DateTimeOffsetExtensions, which is an internal class. Instead, it should beDateTimeOffsetHelper, as it correctly is on all class members.