Log a warning when the version of Microsoft.Data.SqlClient is lower than 5.2.0 #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmarbach
requested review from
mauroservienti,
tmasternak and
poornimanayar
danielmarbach
changed the title
mauroservienti
approved these changes
Mar 1, 2024
|
@danielmarbach Why 5.0.2 as a minimum specifically? Why not latest? |
danielmarbach
force-pushed
the
sql-client-version-check
branch
from
880b960
to
ab0f691
Compare
|
@bording because 5.0.2 contains the memory leak fixes that we care about. I was thinking about mentioning 5.2.0 but technically that is not needed unless we want to make sure besides not running into the memory leak they are also safe with transaction on .NET. I' m good either way. |
…start upgrading to later versions without enforcing them to have Encrypt=true that was introduced in a breaking change in 4.x of the client
danielmarbach
force-pushed
the
sql-client-version-check
branch
from
ab0f691
to
160b548
Compare
|
@bording pushed. Maybe the warning is a bit too specific now. Happy to take suggestions |
bording
reviewed
Mar 1, 2024
src/NServiceBus.Transport.SqlServer/SqlServerTransportInfrastructure.cs
Outdated
Show resolved
Hide resolved
danielmarbach
commented
Mar 1, 2024
src/NServiceBus.Transport.SqlServer/SqlServerTransportInfrastructure.cs
Outdated
Show resolved
Hide resolved
danielmarbach
changed the title
danielmarbach
commented
Mar 1, 2024
src/NServiceBus.Transport.SqlServer/SqlServerTransportInfrastructure.cs
Outdated
Show resolved
Hide resolved
tmasternak
approved these changes
Mar 4, 2024
bording
approved these changes
Mar 4, 2024
danielmarbach
changed the title
danielmarbach
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Microsoft.Data.SqlClient version 3.x referenced in our package has a number of issues that have been addressed in the 5.x versions of the client. Unfortunately, we can't just upgrade that package in a minor, since both version 4.x and 5.x contain a number of breaking changes that might require careful planning on the side of our customers. The next major version of the transport will already have a dependency on 5.2.0. As an intermediate step, we are adding a log warning to inform customers that they should consider upgrading the Sql Client version.
Documentation
None. The warning contains all the information necessary.