Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show window on full screen apps #39

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ParthJadhav
Copy link
Owner

closes: #36

@ParthJadhav
Copy link
Owner Author

Hey @benediktms , The above changes seem to work on Dev environment but doesn't work on release builds. Can you test ?

@benediktms
Copy link
Contributor

@ParthJadhav sure I'll have a look

@benediktms
Copy link
Contributor

benediktms commented Jan 14, 2023

Could you tell me what the requirements are to compile for release (I already installed create-dmg)? The package.json script fails:
Screenshot 2023-01-14 at 10 32 06

When I tested it locally it also worked fine. Does cacao require use to use unsafe rust code in order to work?

@ParthJadhav
Copy link
Owner Author

I think its compiled properly, trying Checking the path it gave above.

@ParthJadhav
Copy link
Owner Author

Also instead of running package-and-build try running yarn tauri build this will generate an .app file and not a dmg

@benediktms
Copy link
Contributor

My bad I actually had the wrong create-dmg installed it works now, but I am getting the same results, release is not handling this correctly... But I'm not sure what the cause could be...

@ParthJadhav
Copy link
Owner Author

@benediktms
Copy link
Contributor

Seems like this is a discussion in the tauri community: tauri-apps/tauri#2801

@ParthJadhav
Copy link
Owner Author

https://github.com/ahkohd/tauri-macos-spotlight-example

Yep, Already read all of them. But one thing stands out is that:
https://github.com/ahkohd/tauri-macos-spotlight-example

This app manages to do everything flawlessly :) I copied over everything and it still doesn't seem to work. Can u try it maybe?

@benediktms
Copy link
Contributor

This repo seems to be using objective-c binding to help manage the window placement? Have you tried that?

@ParthJadhav
Copy link
Owner Author

Yep, I literally copied over everything as it was. Didn't work :(

@benediktms
Copy link
Contributor

Well we can always wait until tauri adds their own implementation I guess...

@ParthJadhav
Copy link
Owner Author

Well we can always wait until tauri adds their own implementation I guess...

Let's do that. I'll put this PR in draft.

@ParthJadhav ParthJadhav marked this pull request as draft January 15, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: launcher appears invisible if used while another application is in fullscreen mode
2 participants