This repository has been archived by the owner on Feb 12, 2018. It is now read-only.
Remove weird things from the Debug configuration. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Debug is apparently the default in MonoDevelop and is required for running the tests, it should be a configuration suitable for development. That means traces (which cause the tests to break) and IronAHK.Program.Start (which causes my brain to break) are no good. If these are really needed, they should be in another configuration that defines TRACE or WTF respectively.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Debug is apparently the default in MonoDevelop and is required for
running the tests, it should be a configuration suitable for development.
That means traces (which cause the tests to break) and IronAHK.Program.Start
(which causes my brain to break) are no good. If these are really needed, they
should be in another configuration that defines TRACE or WTF respectively.
I'm not REALLY expecting you to pull this commit unmodified (not that I think there's anything wrong with it), but please do something because not being able to run tests with MonoDevelop is really crappy.