Fix Kokkos kernels for Kokkos 4.3.0 #641
Open
+2
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kokkos kernels don't compile under the latest release. Math functions such as fabs have been moved from the Kokkos::Experimental namespace to the Kokkos namespace. Additionally, directly including headers aside from Kokkos_Core.hpp is disallowed.
|
It's too bad Travis CI went away and regressions aren't caught anymore. I haven't had time to do GitHub CI yet. Anyways, I'll verify the change and merge soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kokkos kernels don't compile under the latest release. Math functions such as fabs have been moved from the Kokkos::Experimental namespace to the Kokkos namespace. Additionally, directly including headers aside from Kokkos_Core.hpp is disallowed.
#640
Do you certify that your contribution is made in good faith and does not attempt to introduce any negative behavior into this project?