Adding more options for configuring ping passthrough. #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powercasgamer
suggested changes
Apr 16, 2024
proxy/src/main/java/com/velocitypowered/proxy/connection/util/ServerListPingHandler.java
Outdated
Show resolved
Hide resolved
proxy/src/main/java/com/velocitypowered/proxy/connection/util/ServerListPingHandler.java
Outdated
Show resolved
Hide resolved
proxy/src/main/java/com/velocitypowered/proxy/connection/util/ServerListPingHandler.java
Outdated
Show resolved
Hide resolved
proxy/src/main/java/com/velocitypowered/proxy/connection/util/ServerListPingHandler.java
Outdated
Show resolved
Hide resolved
proxy/src/main/java/com/velocitypowered/proxy/connection/util/ServerListPingHandler.java
Outdated
Show resolved
Hide resolved
proxy/src/main/java/com/velocitypowered/proxy/connection/util/ServerListPingHandler.java
Outdated
Show resolved
Hide resolved
|
Those changes are fine. |
…ServerListPingHandler.java Co-authored-by: powercas_gamer <cas@mizule.dev>
…ServerListPingHandler.java Co-authored-by: powercas_gamer <cas@mizule.dev>
…ServerListPingHandler.java Co-authored-by: powercas_gamer <cas@mizule.dev>
…ServerListPingHandler.java Co-authored-by: powercas_gamer <cas@mizule.dev>
…ServerListPingHandler.java Co-authored-by: powercas_gamer <cas@mizule.dev>
…ServerListPingHandler.java Co-authored-by: powercas_gamer <cas@mizule.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Velocity, I have been frustrated by the lack of fine control over ping passthrough, specifically the lack of support for passing through favicons without passing through the whole ping request. I've also seen people on line asking how to pass through favicons, so I decided to add the ability to control which aspects of server list ping requests are passed through from the back end server, and which aspects aren't, through 5 new boolean configuration options in the config file.
Please don't judge my code too harshly, this is my first time writing Java, but it does compile and Checkstyle is okay with it.