Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the default Minecraft port instead of custom one #1277

Open
wants to merge 1 commit into
base: dev/3.0.0
Choose a base branch
from

Conversation

Phoenix616
Copy link

@Phoenix616 Phoenix616 commented Mar 29, 2024

Currently Velocity uses the custom port 25577 in its default config which does not make any sense for 99.9% of deployments and has caused confusion and unnecessary support requests time and time again without any obvious benefit as usually you want the proxy to be reachable instead of your normal servers which wouldn't even be usable anymore as soon as you enable proxy support on the Minecraft server. (I kinda assume this was originally just copied from Bungee's default being 25577)

While a non-standard port can be useful for testing in some situations when already having a Minecraft server running in others it might actually be decremental (e.g. because you need to add another server into your server list instead of just using one localhost with port 25565). For cases where this behaviour is desired a custom port can always be specified in the config anyways.

Existing setups should not get influenced by this change as they already have a config with the value and even in a case where a container image is used which relies on a specific port this change should not cause any issues as the config should either be persisted or be part of the container image if it is setup right. (e.g. like how the Velocity Pterodactyl egg does it)

And if there was discussion/issues/PRs open for that before then I'm sorry but I couldn't find them...

@kashike kashike added the type: feature New feature or request label Mar 29, 2024
@rafi67000
Copy link

bungee does the same so idk they probably wanted to keep it the same as bungee.

@electronicboy
Copy link
Member

I generally hit my config over to the default port locally, the only reason for being a non-default port that I can see for quick testing, but, you generally need to configure a bunch of other stuff anyways

I'm generally for merging this, but, need to do it in the next version, not here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants