Preliminary API for 'new' brains AI system for mobs #10462
Draft
+1,124
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannicklamprecht
suggested changes
Apr 27, 2024
patches/server/1060-Implement-preliminary-API-for-working-with-new-mob-A.patch
Outdated
Show resolved
Hide resolved
patches/server/1060-Implement-preliminary-API-for-working-with-new-mob-A.patch
Outdated
Show resolved
Hide resolved
patches/api/0474-Add-preliminary-API-for-working-with-new-mob-AI-syst.patch
Outdated
Show resolved
Hide resolved
|
Feel free to reference #6968 This should support creating own sensors/memories via the bootstrap api. |
pontaoski
force-pushed
the
work/jblackquill/brains
branch
7 times, most recently
from
e101945
to
8b44e8a
Compare
|
how does the way tasks are exposed look? |
pontaoski
force-pushed
the
work/jblackquill/brains
branch
5 times, most recently
from
cf13e06
to
ba28ca2
Compare
|
need to figure out generating the SensorTypeKeys in a more type-safe manner |
kashike
requested changes
May 13, 2024
patches/api/0480-Add-preliminary-API-for-working-with-new-mob-AI-syst.patch
Outdated
Show resolved
Hide resolved
pontaoski
force-pushed
the
work/jblackquill/brains
branch
from
ba28ca2
to
6d8c690
Compare
Would fix PaperMC#10443 if done. This is a rough proposal for abstracting over the brains AI system for mobs for plugins to make use of, similar to the Goals API. I don't think it's feasible to attempt to make the new AI conform to the old interfaces. At the moment I understand the rough skeleton and arteries of the system, though I'm still trying to piece together what does what in user-facing terms. 'get the mob to walk somewhere' has been unsuccessful so far. As far as API stability concerns, as long as the exposed set of tasks isn't too 1:1 with what Mojang has, then we should be fine (until the next Big Rewrite:tm: whenever that is) considering the general stability of the system across versions since its introductions. There are still some unanswered questions in the API design: - do events make sense to have here? I'd say no considering the amount of lambdas in the Minecraft implementation that make any real introspection API unfeasible. - do we care to expose sensors/make them modifiable? It could probably be done in a followup PR to make custom tasks & sensors a thing, as I'm mostly concerned about exposing what exists in Vanilla at the moment. - is the arrangement of the entrypoints to the new API sensical? Test plugin is included in PR to ease testing of the new API until it's ready to ship.
pontaoski
force-pushed
the
work/jblackquill/brains
branch
from
6d8c690
to
84fdee9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would fix #10443 if done.
This is a rough proposal for abstracting over the brains AI system for mobs for plugins to make use of, similar to the Goals API. I don't think it's feasible to attempt to make the new AI conform to the old interfaces.
At the moment I understand the rough skeleton and arteries of the system, though I'm still trying to piece together what does what in user-facing terms. 'get the mob to walk somewhere' has been unsuccessful so far.
As far as API stability concerns, as long as the exposed set of tasks isn't too 1:1 with what Mojang has, then we should be fine (until the next Big Rewrite:tm: whenever that is) considering the general stability of the system across versions since its introductions.
There are still some unanswered questions in the API design:
Test plugin is included in PR to ease testing of the new API until it's ready to ship.