Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow server administrators to disable book size checks (on the right branch this time) #10457

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aHalliday13
Copy link

Re-creating this pull request because it was on the wrong branch last time and it was automatically closed. I run a small Minecraft server, and we've been running into issues with the book size check. After struggling to find a suitable configuration, I've made this patch, which allows an admin to disable the book size check by setting page-max in paper-global.yml to -1. This should also fix issue #10354.

@aHalliday13 aHalliday13 requested a review from a team as a code owner April 26, 2024 20:27
@Leguan16
Copy link
Contributor

Should be merged into patches/server/Book-Size-Limits.patch. Although i am not sure if this setting will be available after the update to 1.20.6 since minecraft also removes it.

@aHalliday13
Copy link
Author

Looks like that patch you linked no longer exists? I'll make the necessary changes to this PR, just want to get clarification on what changes to make. Also what exactly are you referring to for 1.20.6? Thanks!

@Leguan16
Copy link
Contributor

It still exists. Just search for Book-size-limit.patch in patches/server. The number in front can change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants