readd itemstack data sanitization #10454
Merged
+228
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Machine-Maker
force-pushed
the
dev/1.20.5-itemstack-data-sanitization
branch
2 times, most recently
from
e4c1e9a
to
7418fee
Compare
|
Rebased and tested, and yes, it does sanitize the data component values correctly where needed. If this format of doing this is O.K., we can add the rest of the missing sanitization functionality. |
Machine-Maker
force-pushed
the
dev/1.20.5-itemstack-data-sanitization
branch
4 times, most recently
from
9502ce6
to
7b99b55
Compare
lynxplay
approved these changes
May 26, 2024
Machine-Maker
force-pushed
the
dev/1.20.5-itemstack-data-sanitization
branch
from
7b99b55
to
a45dbb9
Compare
Machine-Maker
force-pushed
the
dev/1.20.5-itemstack-data-sanitization
branch
from
a45dbb9
to
57b304a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just an initial idea for how to do the itemstack sanitization with the new stream codec system. Needs to be tested once compile issues are fixed.