Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BlockSearchPlayersEvent #10288

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

notTamion
Copy link
Contributor

resolves #10137
no idea if there are any other blocks that grant effects, conduits and beacons are the only ones i know of

@notTamion notTamion requested a review from a team as a code owner February 28, 2024 18:13
@molor
Copy link

molor commented Feb 28, 2024

BlockSearchPlayerEvent sounds better IMO

@notTamion
Copy link
Contributor Author

I agree, however i will wait since i am sure maintainers are gonna have something to say about the naming too

@notTamion notTamion force-pushed the Add-BlockPlayerSearchEvent branch 2 times, most recently from 07549b0 to 958d301 Compare April 28, 2024 12:38
@kashike kashike added the type: feature Request for a new Feature. label Apr 29, 2024
@kennytv
Copy link
Member

kennytv commented May 1, 2024

I'd say BlockSearchPlayersEvent

@notTamion notTamion force-pushed the Add-BlockPlayerSearchEvent branch from f600839 to fa793dc Compare May 1, 2024 14:00
@notTamion notTamion changed the title Add BlockPlayerSearchEvent Add BlockSearchPlayersEvent May 1, 2024
@notTamion notTamion force-pushed the Add-BlockPlayerSearchEvent branch from fa793dc to 93058da Compare May 1, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature Request for a new Feature.
Projects
Status: Awaiting review
Development

Successfully merging this pull request may close these issues.

Add BlockApplyEffectsEvent
4 participants