Cut/copy/paste, multiple selection, and Edit menu #59
Conversation
Still needs: - Rotation correction - Box select
…ulti-select rotation
…ng select-all twice
Dewb
changed the title
|
There does appear to still be a transform bug with fills, but I haven't been able to reproduce it reliably yet. |
|
I'd like to thank you personally for you work on this, unfortunately there's no maintainer currently on the project to properly handle PR's that need a bit of extra work to fold into existing plans. I am being contracted to work on the 1.2.0 release which first calls for Undo/Redo functionality, and a number of other overlapping features, which unfortunately necessitates that I close this PR. I admit some of your implementation is better, and if you want to try to integrate some of your additions/edits once 1.2.0 is released, hopefully I can assist in merging. I hate to see good work wasted. |
|
Thanks for responding. I can certainly take a stab at re-integrating anything that's still useful post-1.2.0. The work wasn't wasted, it's been very useful to me at least, hopefully it can be useful to others eventually. I understand the challenges involved in bootstrapping a new open-source software project. If there is no maintainer available to review PRs, it might be a good idea to adjust the language in the README in the "Want to add a new feature?" section under "Problems?" that explicitly lays out a PR review procedure. |
|
Unfortunately, we don't have one yet. Until Storebound can confirm they want to pay (even minimal time) for a maintainer, all PRs and issues are being handled "ad-hoc" by either Storebound employees or @PancakeBot (PancakeBot creator Miguel Valenzuela himself), or simply not handled at all. The original language was created in the hopes that incoming PRs would persuade Storebound to better understand the basic concepts of modern open source contribution, though it appears this is still a difficult concept to grasp for those new to the software game as they are. Even an entirely volunteer maintainer would have to contend with Storebound's needs/wishes, and writing new features which though technically given to the community, directly support a for-profit company not fully dedicated to open source. I still have hope that understanding can be found, though it appears Storebound is commonly too busy to prioritize this. I'll discuss with them privately if they can make time for this and will get back to you. |
|
Does anyone know, if these features are soon available in one of the offical releases. |
|
They are available in the 1.3.0 beta release, along with auto tracing. Have you tried downloading that version?
Kind Regards,
Slim Geransar
slim@storebound.com<mailto:slim@storebound.com>
[cid:CE92FAD3-CF75-4CDD-A3D3-9B390309CBAB]
On Oct 6, 2017, at 3:27 AM, blanso <notifications@github.com<mailto:notifications@github.com>> wrote:
Does anyone know, if these features are soon available in one of the offical releases.
Since these are crucial for usability it would be great if we can have access to this functionality!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#59 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AM0bsCAMJB4RVhlCcDVDRjn3E3qm4c9nks5spgCPgaJpZM4HWIY8>.
|
|
Ah ok, thanks for informing me about this version. Didn't know, that there
was a newer beta version available.
I'll try working with this version.
Kind Regards,
Sophie
2017-10-06 16:54 GMT+02:00 Slimmy82 <notifications@github.com>:
… They are available in the 1.3.0 beta release, along with auto tracing.
Have you tried downloading that version?
Kind Regards,
Slim Geransar
***@***.******@***.***>
[cid:CE92FAD3-CF75-4CDD-A3D3-9B390309CBAB]
On Oct 6, 2017, at 3:27 AM, blanso ***@***.***<mailto:
***@***.***>> wrote:
Does anyone know, if these features are soon available in one of the
offical releases.
Since these are crucial for usability it would be great if we can have
access to this functionality!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<https://github.com/
PancakeBot/PancakePainter#59#issuecomment-334718241>, or mute the
thread<https://github.com/notifications/unsubscribe-auth/
AM0bsCAMJB4RVhlCcDVDRjn3E3qm4c9nks5spgCPgaJpZM4HWIY8>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#59 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APWfZd-w4QepSLsxBlRw9Mw0SYwzH1c-ks5spj8zgaJpZM4HWIY8>
.
|
What this pull request does
Issues addressed
#57 Add support for select-all resizing
#54 Group selection and group scaling/movement
#48 Copy and paste functionality
#32 Wish list (sixth bullet "Multi-select")
Testing performed
Notes
applyMatrixto make sure successive multiple-selection rotations and scales are applied correctly. There may be a better way to manage this, possibly by leavingapplyMatrixon all the time and directly applying all transformations. I instead erred on the side of making fewer changes to the code. It works, but if new editing tools are added they'll likely need similarapplyMatrixhacks.