[CINN] Add symbolic select #63971
Merged
[CINN] Add symbolic select #63971
+214
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
hxzd5568
force-pushed
the
select
branch
2 times, most recently
from
e0b4244
to
50500ec
Compare
hxzd5568
force-pushed
the
select
branch
2 times, most recently
from
182593f
to
b8bb79e
Compare
Aurelius84
reviewed
May 10, 2024
| cond_dims.size(), | ||
| x_dims.size())); | ||
| size_t cond_dims_size = static_cast<size_t>(cond_dims.size()); | ||
| for (size_t i = 0; i < cond_dims_size; ++i) { |
There was a problem hiding this comment.
这里对于cond_dim、x_dim、y_dim的比较逻辑看起来是一致的，可以考虑使用lambda函数服用逻辑
| return paddle.tensor.where(cond, true_branch.sin(), false_branch) | ||
|
|
||
|
|
||
| class TestWhere(unittest.TestCase): |
There was a problem hiding this comment.
这里建议继承 base.py 里的TestBase，只重写 init函数逻辑即可。
Aurelius84
approved these changes
May 10, 2024
zyfncg
approved these changes
May 10, 2024
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
May 11, 2024
* fix where op infer meta check * convert where to cinn select * convert where to cinn select * [CINN] add symbolic select for where --------- Co-authored-by: phlrain <phliuhongyu@126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
New features
Description
Pcard-83399
We add symbolic select.