Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add THIRD_PARTY_PATH #1098

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Jan 9, 2017

No description provided.

@reyoung reyoung requested a review from gangliao January 9, 2017 07:20
@reyoung
Copy link
Collaborator Author

reyoung commented Jan 9, 2017

Also maybe we could add cache for this libraries in TravisCI. See https://docs.travis-ci.com/user/caching/#Arbitrary-directories.

I will give another PR for it.

@@ -43,6 +43,16 @@ option(WITH_DOC "Compile PaddlePaddle with documentation" OFF)
option(ON_COVERALLS "Compile PaddlePaddle with code coverage" OFF)
option(COVERALLS_UPLOAD "Package code coverage data to coveralls" OFF)
option(ON_TRAVIS "Exclude special unit test on Travis CI" OFF)

# CMAKE_BUILD_TYPE
if(NOT CMAKE_BUILD_TYPE)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMAKE_BUILD_TYPE 也是一个configuration variable

@gangliao gangliao merged commit cb0a1e2 into PaddlePaddle:develop Jan 9, 2017
@reyoung reyoung deleted the feature/make_third_party_directory_configurable branch January 18, 2017 06:14
zhhsplendid pushed a commit to zhhsplendid/Paddle that referenced this pull request Sep 25, 2019
* fixed link error for install doc in develop
wangxicoding pushed a commit to wangxicoding/Paddle that referenced this pull request Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants