Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

转换规则No65 torch.nn.functional.threshold #121

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

转换规则No65 torch.nn.functional.threshold #121

wants to merge 21 commits into from

Conversation

Liyulingyue
Copy link
Contributor

PR Docs

根据表格信息，对应文档已存在，未找到对应PR

PR APIs

torch.nn.functional.threshold

API Discriptions

#112 case 65

@paddle-bot
Copy link

paddle-bot bot commented Jun 23, 2023

Thanks for your contribution!

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jun 23, 2023
@Liyulingyue
Copy link
Contributor Author

需要帮忙看一下为啥子没过

@ROckDog22
Copy link
Contributor

ROckDog22 commented Jun 26, 2023 •
edited

需要帮忙看一下为啥子没过
image
这里可能需要先判断是否存在inplace参数
@Liyulingyue

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jun 26, 2023
@Liyulingyue Liyulingyue changed the title [convert] torch.nn.functional.threshold 转换规则No65 torch.nn.functional.threshold Jun 27, 2023
ROckDog22
ROckDog22 reviewed Jun 28, 2023
View reviewed changes
paconvert/api_mapping.json Outdated
@@ -390,6 +390,16 @@
"input": "x"
}
},
"torch.nn.functional.threshold": {
"Matcher": "FunctionalThresholdMatcher",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个inplace参数paddle目前还不支持，改成不支持参数就行

@luotao1 luotao1 self-assigned this Jun 29, 2023
@luotao1 luotao1 mentioned this pull request Jul 3, 2023
Closed
@luotao1
Copy link
Collaborator

luotao1 commented Jul 7, 2023

请解决下UnitTest的单测问题

zhwesky2010
zhwesky2010 reviewed Jul 24, 2023
View reviewed changes
paconvert/api_mapping.json Outdated
},
"unsupport_args": [
"value",
"inplace"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个inplace可以改写到kwargs_change里去直接删除：

"kwargs_change": {
    "inplace": ""
}

tests/test_nn_functional_threshold.py Show resolved Hide resolved
@luotao1
Copy link
Collaborator

luotao1 commented Aug 18, 2023

@Liyulingyue 张师傅，别忘了这里还有单测失败要修哈

Liyulingyue
Liyulingyue commented Aug 19, 2023
View reviewed changes
tests/test_nn_functional_threshold.py Outdated Show resolved Hide resolved
tests/test_nn_functional_threshold.py Outdated Show resolved Hide resolved
tests/test_nn_functional_threshold.py Outdated Show resolved Hide resolved
tests/test_nn_functional_threshold.py Outdated Show resolved Hide resolved
@zhwesky2010
Copy link
Collaborator

infoflow 2023-08-29 11-12-09

单测未通过

@Liyulingyue
Copy link
Contributor Author

infoflow 2023-08-29 11-12-09

单测未通过

这个单测未通过的问题我觉得有点奇怪，看上去在说没有这个转换规则？
我再调试调试

@zhwesky2010
Copy link
Collaborator

zhwesky2010 commented Sep 4, 2023 •
edited

infoflow 2023-08-29 11-12-09
单测未通过

这个单测未通过的问题我觉得有点奇怪，看上去在说没有这个转换规则？ 我再调试调试

@Liyulingyue 是的，转换完后的代码是包含 >>> 的 ，因为你这个unsupport_args配置了第三个参数value，则会触发不支持

@Liyulingyue
Copy link
Contributor Author

infoflow 2023-08-29 11-12-09
单测未通过

这个单测未通过的问题我觉得有点奇怪，看上去在说没有这个转换规则？ 我再调试调试

@Liyulingyue 是的，转换完后的代码是包含 >>> 的 ，因为你这个unsupport_args配置了第三个参数value，则会触发不支持

那该咋改捏qwq

@zhwesky2010
Copy link
Collaborator

zhwesky2010 commented Sep 5, 2023 •
edited

infoflow 2023-08-29 11-12-09
单测未通过

这个单测未通过的问题我觉得有点奇怪，看上去在说没有这个转换规则？ 我再调试调试

@Liyulingyue 是的，转换完后的代码是包含 >>> 的 ，因为你这个unsupport_args配置了第三个参数value，则会触发不支持

那该咋改捏qwq

这个API正在进行功能增强，等支持了value参数后就可以正常开展，预计9月份支持value

@zhwesky2010
Copy link
Collaborator

目前还未完成支持value

@Liyulingyue
Copy link
Contributor Author

目前还未完成支持value

get，需要先把pr关闭吗~？

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhwesky2010 zhwesky2010 zhwesky2010 left review comments

@ROckDog22 ROckDog22 ROckDog22 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@luotao1 luotao1

@zhwesky2010 zhwesky2010

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR status: proposed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Liyulingyue @ROckDog22 @luotao1 @zhwesky2010