Skip to content
This repository has been archived by the owner on Mar 16, 2022. It is now read-only.

too many arguments for format string #640

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peterjc
Copy link

@peterjc peterjc commented May 30, 2018

Spotted via the compiler warnings trying to build FALCON locally,

src/c/DW_banded.c: In function ‘my_calloc’:
src/c/DW_banded.c:109:17: warning: too many arguments for format [-Wformat-extra-args]
                 msg, nitems, size, lineno);
                 ^

This change expands the logging to record the line number argument.
The message could be logged too, but might be long, so I have included
the ellipse in the message to indicate there is another argument to
calloc not being recorded.

Spotted via the compiler warnings trying to build FALCON locally,

```
src/c/DW_banded.c: In function ‘my_calloc’:
src/c/DW_banded.c:109:17: warning: too many arguments for format [-Wformat-extra-args]
                 msg, nitems, size, lineno);
                 ^
```

This change expands the logging to record the line number argument.
The message could be logged too, but might be long, so I have included
the ellipse in the message to indicate there is another argument to
calloc not being recorded.
@peterjc
Copy link
Author

peterjc commented May 30, 2018

The TravisCI failure looks unrelated?

============================= test session starts ==============================
platform linux2 -- Python 2.7.6, pytest-3.6.0, py-1.5.3, pluggy-0.6.0 -- /usr/bin/python
cachedir: .pytest_cache
rootdir: /home/travis/build/PacificBiosciences/FALCON, inifile: setup.cfg
collecting 0 items                                                             falcon-kit 1.1.1+git.719651e8e32a20e324431ec2343a36b85f36066c
pypeflow 2.0.2+git.cb894bb12a19eba6cdda2a2485bf8a5cbeadda9d
collected 115 items / 2 errors                                                 
==================================== ERRORS ====================================
__________________ ERROR collecting test/test_util_system.py ___________________
test/test_util_system.py:20: in <module>
    @pytest.fixture(scope="session")
LOCAL/lib/python2.7/site-packages/_pytest/fixtures.py:919: in yield_fixture
    "function", params, autouse, ids=ids, name=name)(scope)
LOCAL/lib/python2.7/site-packages/_pytest/fixtures.py:857: in __call__
    "fixture is being applied more than once to the same function")
E   ValueError: fixture is being applied more than once to the same function
__________________ ERROR collecting test/test_util_system.py ___________________
test/test_util_system.py:20: in <module>
    @pytest.fixture(scope="session")
LOCAL/lib/python2.7/site-packages/_pytest/fixtures.py:919: in yield_fixture
    "function", params, autouse, ids=ids, name=name)(scope)
LOCAL/lib/python2.7/site-packages/_pytest/fixtures.py:857: in __call__
    "fixture is being applied more than once to the same function")
E   ValueError: fixture is being applied more than once to the same function
-- generated xml file: /home/travis/build/PacificBiosciences/FALCON/test.xml ---
!!!!!!!!!!!!!!!!!!! Interrupted: 2 errors during collection !!!!!!!!!!!!!!!!!!!!
=========================== 2 error in 0.68 seconds ============================
make: *** [test] Error 2

@peterjc
Copy link
Author

peterjc commented May 30, 2018

Should this be submitted as a change against the develop branch? If so, why not make that the default branch on GitHub?

@pb-cdunn
Copy link

You're right: develop should be the default branch. But the code in GitHub is no longer kept up-to-date anyway. (We host internally now.)

Thanks for fixing the typo. We'll grab your commit soon ...

@pb-cdunn pb-cdunn self-assigned this Jun 22, 2018
@peterjc
Copy link
Author

peterjc commented Jun 22, 2018

Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants