This repository has been archived by the owner on Mar 16, 2022. It is now read-only.
Update run.py to support Torque qsub #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for PBS torque job_type = "torque" can now be used in the CFG file Here is an example of what to place in the CFG file job_type = torque sge_option_da = -l nodes=1:ppn=16:compute,walltime=4:00:00 sge_option_la = -l nodes=1:ppn=16:compute,walltime=4:00:00 sge_option_pda = -l nodes=1:ppn=16:compute,walltime=4:00:00 sge_option_pla = -l nodes=1:ppn=16:compute,walltime=4:00:00 sge_option_fc = -l nodes=1:ppn=16:compute,walltime=4:00:00 sge_option_cns = -l nodes=1:ppn=16:compute,walltime=4:00:00
|
We definitely want torque support, but the new code looks almost the same as sge. It has |
|
Yes, it is the correct option parameter for -j on systems with torque. |
|
Ok. I couldn't find anything on For reference: Common commands in TORQUE and SGE. |
|
Added to FAQ. |
|
I worked it out with our HPC guys and have it working with torque |
pb-cdunn
pushed a commit
that referenced
this pull request
Oct 19, 2015
Update run.py to support Torque qsub
|
Sorry. Somehow I had accidentally closed instead of merging. |
pb-cdunn
pushed a commit
to pb-cdunn/FALCON
that referenced
this pull request
Apr 18, 2019
…-erc_from_daligner to develop * commit 'e48b9efebbcb254d83341fd21a6d6280fb482dd6': The falcon_kit.mains.consensus can now accept externally provided mapping coordinates together with the sequences. If provided, and if an optional argument --allow-external-mapping is specified, the error correction code will not map internally. - Refactoring of the code duplication in get_consensus_with_trim and get_consensus_without_trim. - Added a SeqTuple named tuple in the consensus.py, to allow simpler passing of additional arguments. - Updated the falcon_kit/mains/consensus.py to be able to output the alignment ranges provided by DALIGNER all the way to the consensus .c code. - The new feature of using external coordinates is a no-op unless --allow-external-mapping is specified. This is intentionally done to feature flag it. The error correction stage can now accept external mapping coordinates. - Implemented the generate_consensus_from_mapping which uses the mapping coordinates provided via the parameters. Added log statements around asserts. Added some debug logging too. - Properly handling leading indels in generate_consensus_from_mapping now. The get_cns_from_align_tags method expects the first op to be a match/mismatch, and this causes out of bounds issues when adding edges to the predecessor. - Additionally, range coordinates passed to get_align_tags needed to be updated as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for PBS torque.
job_type = torquecan now be used in the CFG file.Here is an example of what to place in the CFG file