Commits on Jul 11, 2019

1. Refactor solve_lp_for_year.py …

   *Not ready to merge*
   
   In filing PSLmodels#323 I looked through this file, and took a stab at streamlining the code. Changes include:
   1. Using a `wage_bin` function to create wage bins.
   2. Using a loop to assign `lhs_vars` dictionary elements.*
   3. Using a loop to assign factor variables.
   4. Using an `add_target` function to assign `rhs_vars` dictionary elements.*
   5. More explicitly adjust `model_vars` for year 2014.
   6. Rename `LP` to `lp` since it's not a constant.
   7. Other minor changes like comments.
   
   \* These pieces won't currently work since they attempt to access `globals()` from within a function (`locals()` also won't work). Per https://stackoverflow.com/q/56983782/1840471, there's no good way to access these, and this is really a sign that something could be done better. It seems to me that sticking with the dictionary elements rather than creating new variables would be a clean alternative.
   
   I haven't tested this code yet. Would the right way be to run `make cps-files`?

   

   MaxGhenis committed Jul 11, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for c1c1a50
   • Browse repository at this point

   Copy the full SHA

   c1c1a50 View commit details

   Browse the repository at this point in the history