[draft] Add Span to our Lexer error #4463
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the issue is that the stream which the lexer consumes needs to be composed of tokens which contain the span, so not just `char`. So if we want to do this, we need to pass in a different stream, not just a &str
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@m-span re your message on Discord — FYI a few weeks ago I tried to add
Spanto the lexer error, to try and unify the error types (so we're thinking similar things!).But I got arcane chumsky errors and didn't manage to figure it out. If you can, great, but also this may be a warning beacon that it's not so easy...