fix: Raise an error on unavailable excludes #2342
Open
+28
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes PRQL#2292. It was here deliberately (the old code was _more_ work). I would think it's better to raise here — getting this wrong is still wrong...
|
Tests are failing because of #2079, so I guess we need to solve that first |
aljazerzen
approved these changes
Apr 2, 2023
There was a problem hiding this comment.
I did not want throw an error here, because we don't have an easy escape path. (see the comment that was removed).
I've pushed a test that exposes this error when using group (take). If you are ok with throwing an error even in this case, we can merge.
For better errors, we'd need to include more spans in RQ.
* chore: bump clap from 4.1.10 to 4.2.0 Bumps [clap](https://github.com/clap-rs/clap) from 4.1.10 to 4.2.0. - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md) - [Commits](clap-rs/clap@v4.1.10...clap_complete-v4.2.0) --- updated-dependencies: - dependency-name: clap dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Maximilian Roos <m@maxroos.com>
* -added docker compose -added test skeleton * -added dependencies * -added real test cases * -added mssql * refactoring * -added go-task * -more testcases * -added github workflow * -fixed formatting * -fixed linting * -fixed workflow yaml * -fixed workflow yaml again * -added more testcases * Apply suggestions from code review Co-authored-by: eitsupi <50911393+eitsupi@users.noreply.github.com> * -refactored test workflow * Fix order of args to `assert_display_snapshot` Sorry for the incorrect suggestion prior! * Specify platform for mysql image * -added csv import * -fixed or skipped all prql files * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * -fixed sqlite * added snaps§ * Update prql-compiler/prqlc/src/cli.rs * -removed test on macOS * empty * -skip integration test on windows * -fixed taskfile * -added double quotes * Update .github/workflows/test-rust.yaml --------- Co-authored-by: eitsupi <50911393+eitsupi@users.noreply.github.com> Co-authored-by: Maximilian Roos <m@maxroos.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
* build: disable tsqllint in megalinter * build: add sqlfluff config file * format: autoformatting by sqlfluff * build: ignore `references.keywords` rule of sqlfluff
* refactor: Use tags for the language code blocks Idea from PRQL#2348 * change to spaces
* Update CHANGELOG.md * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update CHANGELOG.md --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
We can't hit this since the `*` case is covered above IIUC
…instead of conf file (PRQL#2359) * chore(test): remove unused mysql conf file * fix: pass `--secure-file-priv=""` via compose file
Close PRQL#2344 Since `prql` code blocks in md files included in the Book will evaluated and replace with html, this PR introduce a new Option `no-eval` that modifies the Book preprocessor to not evaluate Changelog's `prql` code blocks. Also add a pre-commit hook to avoid using bare `prql` code blocks on `CHANGELOG.md`. --------- Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
There are two cases I can see:
|
When there is There may be other cases where a column is added and should later be removed without removing the unknown columns, but I cannot think of any right now. |
Good point. Ideally we'd be able to handle those cases differently, I recognize that will require more work though. I'll leave this open for a bit and see whether I / someone else gets to it. Otherwise we can close and attempt a broader effort. |
max-sixty
added a commit
to max-sixty/prql
that referenced
this pull request
Apr 14, 2023
This has been sitting in PRQL#2342, which likely won't get merged, so adding it here.
max-sixty
added a commit
that referenced
this pull request
Apr 14, 2023
This has been sitting in #2342, which likely won't get merged, so adding it here.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2292.
But I now realize was here deliberately (the old code was more work than mine!)
That said I would think it's better to raise here — getting this wrong is still wrong...