Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add wheel task, use in CI #1618

Closed
wants to merge 10 commits into from
Closed

Conversation

max-sixty
Copy link
Member

@max-sixty max-sixty commented Jan 24, 2023

This lets us build & test locally

run: nox -s tests -f bindings/prql-python/noxfile.py
- run: pip install maturin
- name: Build wheel
run: task build-python-wheel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wheels have already been built.

jobs:
build-python-wheels:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [macos-latest, windows-latest]
include:
- os: ubuntu-latest
target: x86_64
- os: ubuntu-latest
target: aarch64
- os: ubuntu-latest
target: source
steps:
- name: 📂 Checkout code
uses: actions/checkout@v3
- name: Build wheel
uses: ./.github/actions/build-prql-python
with:
target: ${{ matrix.target }}
test:
needs: [build-python-wheels]
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]

@max-sixty
Copy link
Member Author

Thanks for reviewing — I should probably either finish this or merge it, sorry for leaving it hanging for so long...

@max-sixty
Copy link
Member Author

Note to future self (or if someone else finishes this) — we should add the ability to use maturin develop, since that installs the python package in a single step.

CI etc uses maturin build + pip install, which is a more complete installation path and better simulates how it'll be used, but requires an extra step + a path change

@max-sixty
Copy link
Member Author

Most of this was added in a separate PR

@max-sixty max-sixty closed this May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants