Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added snapcraft icon #2318

Merged
merged 5 commits into from May 16, 2024
Merged

Added snapcraft icon #2318

merged 5 commits into from May 16, 2024

Conversation

okineadev
Copy link
Sponsor Contributor

Closes #2291

Copy link

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

Copy link

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

Copy link

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

@okineadev
Copy link
Sponsor Contributor Author

Generated Preview

Now the icon is more visible on a white background

@okineadev
Copy link
Sponsor Contributor Author

knuckles-approved

@PKief PKief force-pushed the main branch 2 times, most recently from 368ca9b to 7acb299 Compare May 11, 2024 09:45
@okineadev
Copy link
Sponsor Contributor Author

@PKief

@PKief
Copy link
Owner

PKief commented May 15, 2024

@okineadev thanks for the reminder, I'll have a look tonight.

@PKief PKief self-requested a review May 15, 2024 19:05
Copy link

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

@okineadev
Copy link
Sponsor Contributor Author

okineadev commented May 15, 2024

Gypsy tricks

Copy link

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

Copy link

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

@PKief
Copy link
Owner

PKief commented May 15, 2024

Gypsy tricks

🤫

@okineadev
Copy link
Sponsor Contributor Author

When will you merge the changes?

@PKief PKief merged commit 0b49248 into PKief:main May 16, 2024
4 checks passed
Copy link

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the marketplace.

@okineadev
Copy link
Sponsor Contributor Author

Hooray victory victory PR merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icon Request] snap
2 participants