Modernize svgo config

[Repiteo]

Using the svgo command gives a warning that extendDefaultPlugins is now deprecated, instead recommending the new format seen here. While doing this, I tested some other optional features that weren't yet used; after seeing that they had negligible to nonexistant impact, these options have been added: multipass, convertStyleToAttrs, and sortAttrs

This command should probably be getting more love, as virtually every single svg can be optimized. Maybe a pre-commit hook could be considered? I've heard good things about Husky, might look into that later 🤔

[PKief]

Thanks a lot! I agree with you, that this command should definitely be used more often. As already mentioned (here), I'm not a big fan of pre-commit hooks. I would rather prefer it if we could, for example, optimise all SVG files as part of the release action.

[Repiteo]

Haven't messed with workflow actions much, but I'm pretty sure it's now setup to do just that!

[PKief]

@Repiteo It looks very good, it was exactly what I initially thought. I'll test your changes soon, but I'm agreeing with you, it should work like that.

[PKief]

I've updated the release.yml file a bit. It's important to run "git add ..." to include the changed files in the version commit. In addition, I've moved the "preversion" script into the release.yml file because it looks more structured and more clean.

[github-actions]

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the marketplace.

[lucas-labs]

I've updated the release.yml file a bit. It's important to run "git add ..." to include the changed files in the version commit. In addition, I've moved the "preversion" script into the release.yml file because it looks more structured and more clean.

@PKief, I think this will generate a npm ERR! Git working directory not clean error. It happened to me in my fork and I discovered that npm version apparently requires that all files are added as part of the version or preversion script.

See npm/npm#8620 and npm version documentation

From the docs:

Run the preversion script. These scripts have access to the old version in package.json. A typical use would be running your full test suite before deploying. Any files you want added to the commit should be explicitly added using git add.

Apparently, trying to git add files before preversion or version (e.g. as part of the release action) will throw:

npm ERR! Git working directory not clean.

[PKief]

I've updated the release.yml file a bit. It's important to run "git add ..." to include the changed files in the version commit. In addition, I've moved the "preversion" script into the release.yml file because it looks more structured and more clean.

@PKief, I think this will generate a npm ERR! Git working directory not clean error. It happened to me in my fork and I discovered that npm version apparently requires that all files are added as part of the version or preversion script.

See npm/npm#8620 and npm version documentation

From the docs:

Run the preversion script. These scripts have access to the old version in package.json. A typical use would be running your full test suite before deploying. Any files you want added to the commit should be explicitly added using git add.

Apparently, trying to git add files before preversion or version (e.g. as part of the release action) will throw:

npm ERR! Git working directory not clean.

Thank you for the hint. You're right and I forgot about it. I changed it, so that all scripts are executed via "preversion" npm script.