Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add seeders folder icons #2298

Merged
merged 4 commits into from Apr 23, 2024
Merged

Add seeders folder icons #2298

merged 4 commits into from Apr 23, 2024

Conversation

NotReeceHarris
Copy link
Contributor

@NotReeceHarris NotReeceHarris commented Apr 22, 2024 •
edited

closes #2297

image

@github-actions GitHub Actions
Copy link

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

@github-actions GitHub Actions
Copy link

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

@github-actions GitHub Actions
Copy link

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

@lucas-labs
Copy link
Contributor

Hi @NotReeceHarris, in v5.0.0 there was a change in the shape of the folders, to make them look sharper at 16x16px, which is the default size of the icons in vscode.

image

It's not super noticeable but it's there, and it's much more obvious if you zoom in:

image

image

lucas-labs
lucas-labs reviewed Apr 22, 2024
View reviewed changes
Copy link
Contributor

@lucas-labs lucas-labs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #2298 (comment)

icons/folder-seeders-open.svg Outdated Show resolved Hide resolved
icons/folder-seeders.svg Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

@NotReeceHarris
Copy link
Contributor Author

NotReeceHarris commented Apr 22, 2024 •
edited

image

New Project(1)

New Project(13)

lucas-labs
lucas-labs approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@lucas-labs lucas-labs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shape looks ok, and #a5d6a7 is part of the material palette =)

@PKief PKief merged commit 5679eab into PKief:main Apr 23, 2024
4 checks passed
@github-actions GitHub Actions
Copy link

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the marketplace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-labs lucas-labs lucas-labs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Icon Request] seeders folder
3 participants
@NotReeceHarris @lucas-labs @PKief