feat: Pseudo-wildcard support for folder icons #2292
Merged
+199
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repiteo
force-pushed
the
folder-pseudo-wildcard
branch
from
8128dd6
to
71ebf77
Compare
PKief
requested changes
Apr 22, 2024
There was a problem hiding this comment.
Thank you for this PR, it looks very good 👍 One thing I'd like to see is an adjustment in the contributing guide, so that future editors will know that they don't need to add these wildcards to the folder names as they are set automatically.
An update here would be appreciated:
https://github.com/PKief/vscode-material-icon-theme/blob/main/CONTRIBUTING.md#folder-icons
Repiteo
force-pushed
the
folder-pseudo-wildcard
branch
from
71ebf77
to
89e411e
Compare
PKief
approved these changes
Apr 23, 2024
Merge SuccessfulThanks for your contribution! 🎉 The changes will be part of the upcoming update on the marketplace. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of needing to put in individual prefix/suffix symbols for certain folder names, this PR aims to make that process implicit. What's more, they're now globally applicable, so ANY folder name can make use of them. This would be rendered irrelevant if actual wildcard/regex support is eventually added to the API, but that's been on the backburner for a loooong time so I wouldn't hold my breath.