Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ES translation #2286

Merged
merged 2 commits into from Apr 20, 2024
Merged

Updated ES translation #2286

merged 2 commits into from Apr 20, 2024

Conversation

Sikriet
Copy link
Contributor

@Sikriet Sikriet commented Apr 20, 2024

Add missing Spanish translation.

@lucas-labs
Copy link
Contributor

lucas-labs commented Apr 20, 2024

Since we're changing this file, besides adding the missing phrases, we could take advantage of the opportunity and also fix those phrases that seem a bit off in the current translation.

I'm specifically referring to the phrases that use the third person singular verb instead of using the infinitive. For example, 'Seleccione un paquete de iconos que permita iconos específicos.' should be 'Seleccionar un paquete de íconos'.

Note

It's not that those phrases are invalid in Spanish per-se, but they sound a bit off in context and are inconsistent with the rest of the translations. Typically, the infinitive is used for options that imply an action. For example, the follwing screenshot from Chrome:

image
Notice how they used "Asignar" instead of "Asigne" or "Asigna"

@lucas-labs
Copy link
Contributor

To clarify, I'm referring to something like:

{
  ...
-  "configuration.activeIconPack": "Seleccione un paquete de iconos que permita iconos específicos.",
+  "configuration.activeIconPack": "Seleccionar un paquete de iconos que permita iconos específicos.", 
  ...
-  "configuration.folders.theme": "Seleccione el tipo de iconos de carpeta.",
+  "configuration.folders.theme": "Seleccionar el tipo de iconos de carpeta.",
-  "configuration.folders.theme.specific": "Seleccione iconos de carpeta específicos.",
+  "configuration.folders.theme.specific": "Seleccionar iconos de carpeta específicos.",
-  "configuration.folders.theme.classic": "Seleccione iconos de carpetas clásicas.",
+  "configuration.folders.theme.classic": "Seleccionar iconos de carpetas clásicas.",
  ...
-  "configuration.folders.color": "Cambia el color de las carpetas.",
+  "configuration.folders.color": "Cambiar el color de las carpetas.",
  ...
-  "configuration.opacity": "Cambia la opacidad de los iconos.",
+  "configuration.opacity": "Cambiar la opacidad de los iconos.",
  ...
}

@PKief
Copy link
Owner

PKief commented Apr 20, 2024

@Sikriet would you be able to verify @lucas-labs's suggestions and incorporate it into this PR? I would be grateful for some feedback on this as I'm not a native Spanish speaker.

@Sikriet
Copy link
Contributor Author

Sikriet commented Apr 20, 2024

Yeah. Makes sense @lucas-labs . I will apply it into this PR @PKief.

Copy link
Contributor

@lucas-labs lucas-labs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a native spanish speaker, LGTM =)

@PKief PKief merged commit 5b10c5a into PKief:main Apr 20, 2024
2 checks passed
Copy link

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the marketplace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants